Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3355)

Unified Diff: chrome/browser/sync/sync_setup_flow.cc

Issue 8921025: Call SetPassphrase() to re-encrypt the user's data after re-auth. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_setup_flow.cc
diff --git a/chrome/browser/sync/sync_setup_flow.cc b/chrome/browser/sync/sync_setup_flow.cc
index a08bab1cd07ebe150914d5311b827970d0cb88bb..2cd8aa203c9fd7c2564e74e5aa03a9561add6db7 100644
--- a/chrome/browser/sync/sync_setup_flow.cc
+++ b/chrome/browser/sync/sync_setup_flow.cc
@@ -438,6 +438,15 @@ void SyncSetupFlow::ActivateState(SyncSetupWizard::State state) {
}
case SyncSetupWizard::GAIA_SUCCESS:
if (end_state_ == SyncSetupWizard::GAIA_SUCCESS) {
+ // The user has just re-authed - set the passphrase so we can re-encrypt
+ // if necessary. If we are currently encrypting with an explicit
+ // passphrase, this does nothing.
+ // TODO(atwilson): Move all the code dealing with the implicit GAIA
+ // passphrase back into ProfileSyncService in a
+ // NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL listener once we get rid of
+ // SyncSetupFlow.
+ if (!cached_passphrase_.empty())
+ service_->SetPassphrase(cached_passphrase_, false);
flow_handler_->ShowGaiaSuccessAndClose();
break;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698