Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 8921022: GTK: Even more cleanup to access allocation through the accessor. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
9 years ago
Reviewers:
Lei Zhang, sky
CC:
chromium-reviews, dcheng
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Even more cleanup to access allocation through the accessor. BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -20 lines) Patch
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/menu_bar_helper.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc View 5 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
More gtk3 prep cleanup
9 years ago (2011-12-12 22:25:37 UTC) #1
Lei Zhang
lgtm
9 years ago (2011-12-12 22:29:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8921022/1
9 years ago (2011-12-12 22:30:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 8921022-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-12 22:30:11 UTC) #4
Elliot Glaysher
+sky for owners stamp in ui/
9 years ago (2011-12-12 22:40:14 UTC) #5
sky
LGTM
9 years ago (2011-12-13 00:10:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8921022/1
9 years ago (2011-12-13 00:13:09 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-13 02:29:54 UTC) #8
Change committed as 114153

Powered by Google App Engine
This is Rietveld 408576698