Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 8921021: Trivial move of content::BrowserContext to content/public. (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., jam, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Trivial move of content::BrowserContext to content/public. R=avi@chromium.org TBR=rlp@chromium.org BUG=98716 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114651

Patch Set 1 : . #

Patch Set 2 : Merge to head #

Patch Set 3 : Merge to LKGR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -133 lines) Patch
M chrome/browser/profiles/profile.h View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/browser_context.h View 1 chunk +3 lines, -112 lines 0 comments Download
M content/browser/browsing_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/download/download_request_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/drag_download_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/public/browser/browser_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_browser_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_browser_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Jói
9 years ago (2011-12-12 22:22:52 UTC) #1
Avi (use Gerrit)
lgtm
9 years ago (2011-12-13 14:58:05 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 13:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8921021/10001
9 years ago (2011-12-14 14:43:57 UTC) #4
commit-bot: I haz the power
Presubmit check for 8921021-10001 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-14 14:44:07 UTC) #5
M-A Ruel
On 2011/12/14 14:44:07, I haz the power (commit-bot) wrote: > ** Presubmit ERRORS ** > ...
9 years ago (2011-12-14 14:49:39 UTC) #6
Jói
On 2011/12/14 14:49:39, Marc-Antoine Ruel wrote: > On 2011/12/14 14:44:07, I haz the power (commit-bot) ...
9 years ago (2011-12-14 14:52:08 UTC) #7
M-A Ruel
On 2011/12/14 14:49:39, Marc-Antoine Ruel wrote: > But since the CL is trivial, I added ...
9 years ago (2011-12-14 14:53:58 UTC) #8
Jói
For some reason the try servers aren't seeing content/public/browser/browser_context.h, even though it's there in patchset ...
9 years ago (2011-12-14 15:13:52 UTC) #9
M-A Ruel
On 2011/12/14 15:13:52, Jói wrote: > For some reason the try servers aren't seeing > ...
9 years ago (2011-12-14 15:15:22 UTC) #10
Jói
Will continue this debugging in a separate thread, I think I have an idea what ...
9 years ago (2011-12-14 15:16:35 UTC) #11
rpetterson
LGTM for profiles
9 years ago (2011-12-14 19:47:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8921021/17001
9 years ago (2011-12-15 15:42:47 UTC) #13
commit-bot: I haz the power
9 years ago (2011-12-15 16:55:13 UTC) #14
Change committed as 114651

Powered by Google App Engine
This is Rietveld 408576698