Trivial move of content::BrowserContext to content/public.

Trivial move of content::BrowserContext to content/public.

R=avi@chromium.org
TBR=rlp@chromium.org
BUG=98716
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114651

[Avi (use Gerrit), 2011-12-13 14:58:05]

lgtm

[commit-bot: I haz the power, 2011-12-14 13:35:48]

No LGTM from valid reviewers yet.

[commit-bot: I haz the power, 2011-12-14 14:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/8921021/10001

[commit-bot: I haz the power, 2011-12-14 14:44:07]

Presubmit check for 8921021-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/profiles/profile.h

Presubmit checks took 2.3s to calculate.

[M-A Ruel, 2011-12-14 14:49:39]

On 2011/12/14 14:44:07, I haz the power (commit-bot) wrote:
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for: chrome/browser/profiles/profile.h

$ cat chrome/browser/profiles/OWNERS                                            
                                                         set noparent
mirandac@chromium.org
erg@chromium.org
sail@chromium.org
davemoore@chromium.org
rlp@chromium.org
# Primarily for ProfileIOData and friends.
willchan@chromium.org

But since the CL is trivial, I added rlp@ as a TBR committer, so the CL will
pass owner checks.

[Jói, 2011-12-14 14:52:08]

On 2011/12/14 14:49:39, Marc-Antoine Ruel wrote:
> On 2011/12/14 14:44:07, I haz the power (commit-bot) wrote:
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for: chrome/browser/profiles/profile.h
> 
> $ cat chrome/browser/profiles/OWNERS                                          
 
>                                                          set noparent
> mailto:mirandac@chromium.org
> mailto:erg@chromium.org
> mailto:sail@chromium.org
> mailto:davemoore@chromium.org
> mailto:rlp@chromium.org
> # Primarily for ProfileIOData and friends.
> mailto:willchan@chromium.org
> 
> But since the CL is trivial, I added rlp@ as a TBR committer, so the CL will
> pass owner checks.

Thanks Marc-Antoine!

[M-A Ruel, 2011-12-14 14:53:58]

On 2011/12/14 14:49:39, Marc-Antoine Ruel wrote:
> But since the CL is trivial, I added rlp@ as a TBR committer, so the CL will
> pass owner checks.

But right before checking the commit bit again, I realized no try job passed at
compile, with error messages in profile.h so you may want to take a look at the
failures.

[Jói, 2011-12-14 15:13:52]

For some reason the try servers aren't seeing
content/public/browser/browser_context.h, even though it's there in
patchset 10001, which (by looking at git_try.py and [ git config -l ])
looks like what trychange would be invoked with.

I am planning to send a patch manually to the try servers and commit
manually, but let me know if you want me to try debugging.

Cheers,
Jói


On Wed, Dec 14, 2011 at 2:53 PM,  <maruel@chromium.org> wrote:
> On 2011/12/14 14:49:39, Marc-Antoine Ruel wrote:
>>
>> But since the CL is trivial, I added rlp@ as a TBR committer, so the CL
>> will
>> pass owner checks.
>
>
> But right before checking the commit bit again, I realized no try job passed
> at
> compile, with error messages in profile.h so you may want to take a look at
> the
> failures.
>
> http://codereview.chromium.org/8921021/

[M-A Ruel, 2011-12-14 15:15:22]

On 2011/12/14 15:13:52, Jói wrote:
> For some reason the try servers aren't seeing
> content/public/browser/browser_context.h, even though it's there in
> patchset 10001, which (by looking at git_try.py and [ git config -l ])
> looks like what trychange would be invoked with.

That's bad, I'll look into that.

[Jói, 2011-12-14 15:16:35]

Will continue this debugging in a separate thread, I think I have an
idea what the issue is.

On Wed, Dec 14, 2011 at 3:15 PM,  <maruel@chromium.org> wrote:
> On 2011/12/14 15:13:52, Jói wrote:
>>
>> For some reason the try servers aren't seeing
>> content/public/browser/browser_context.h, even though it's there in
>> patchset 10001, which (by looking at git_try.py and [ git config -l ])
>> looks like what trychange would be invoked with.
>
>
> That's bad, I'll look into that.
>
> http://codereview.chromium.org/8921021/

[rpetterson, 2011-12-14 19:47:29]

LGTM for profiles

[commit-bot: I haz the power, 2011-12-15 15:42:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/8921021/17001

[commit-bot: I haz the power, 2011-12-15 16:55:13]

Change committed as 114651