frog: check that const constructors have potentially const initializers. Also

frog/minfrog

 #!/usr/bin/env node
 //  ********** Library dart:core **************
 //  ********** Natives dart:core **************
 /**
  * Generates a dynamic call stub for a function.
  * Our goal is to create a stub method like this on-the-fly:
  *   function($0, $1, capture) { return this($0, $1, true, capture); }
  *
  * This stub then replaces the dynamic one on Function, with one that is
  * specialized for that particular function, taking into account its default
@@ skipping 5581 matching lines @@
             var fname = $i0.next$0();
             fields.$setindex(fname, value.get$fields().$index(fname));
           }
         }
       }
       else {
         var assign = init;
         var x = assign.x;
         var fname = x.get$name().get$name();
         var val = this.generator.visitValue(assign.y);
+        if (!val.get$isConst()) {
+          $globals.world.error('invalid non-const initializer in const constructor', assign.y.span);
+        }
         fields.$setindex(fname, val);
       }
     }
     this.generator._popBlock();
   }
   var $$list = this.declaringType.get$members().getValues();
   for (var $$i = this.declaringType.get$members().getValues().iterator$0(); $$i.hasNext$0(); ) {
     var f = $$i.next$0();
-    if ((f instanceof FieldMember) && !f.get$isStatic() && f.get$value() != null && !fields.containsKey(f.get$name())) {
-      fields.$setindex(f.get$name(), f.computeValue$0());
+    if ((f instanceof FieldMember) && !f.get$isStatic() && !fields.containsKey(f.get$name())) {
+      if (!f.get$isFinal()) {
+        $globals.world.error(('const class "' + this.declaringType.name + '" has non-final ') + ('field "' + f.get$name() + '"'), f.get$span());
+      }
+      if (f.get$value() != null) {
+        fields.$setindex(f.get$name(), f.computeValue$0());
+      }
     }
   }
   return $globals.world.gen.globalForConst(ConstObjectValue.ConstObjectValue$factory(target.get$type(), fields, code, node.span), args.values);
 }
 MethodMember.prototype._invokeBuiltin = function(context, node, target, args, argsCode, isDynamic) {
   var allConst = target.get$isConst() && args.values.every((function (arg) {
     return arg.get$isConst();
   })
   );
   if (this.declaringType.get$isNum()) {
@@ skipping 7614 matching lines @@
   $globals._NO_COLOR = '\u001b[0m';
   $globals._RED_COLOR = '\u001b[31m';
 }
 var const$0 = new EnvMap()/*const EnvMap()*/;
 var const$2 = new EmptyQueueException()/*const EmptyQueueException()*/;
 var const$3 = new _DeletedKeySentinel()/*const _DeletedKeySentinel()*/;
 var const$8 = new NoMoreElementsException()/*const NoMoreElementsException()*/;
 var $globals = {};
 $static_init();
 main();