Issue 8921007: Fix the ownership check for signed settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8921007: Fix the ownership check for signed settings. (Closed)

Created:
9 years ago by pastarmovj

Modified:
9 years ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the ownership check for signed settings. The check was trying to verify the current user is the owner when all it needs to check is if there is an owner already. This check was also blocking local owner from doing changes to the signed settings on first login and possibly is the cause preventing the managed settings from getting applied immediately too. BUG=chromium-os:24020, chromium-os:24007 TEST=As described in the bugs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114212

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/device_settings_provider.cc	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Please review this fix for the DeviceSettingsProvider which should be solving our issues with getting ...

9 years ago (2011-12-12 16:50:10 UTC) #1

Mattias Nissler (ping if slow)

9 years ago (2011-12-12 17:47:39 UTC) #2

LGTM. I don't see how this solves the policy case though since the change you
did only applies to local owners.

Expand Messages | Collapse Messages

Issue 8921007: Fix the ownership check for signed settings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Cleaned up the comment a bit. #

Patch Set 3 : The real comment fix. #

Messages