net/base/x509_cert_types.cc - Issue 8921006: Standardize StringToInt{,64} interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_cert_types.cc

Issue 8921006: Standardize StringToInt{,64} interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix call syntax of StringToInt() in Chrome OS code. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_cert_types.cc

diff --git a/net/base/x509_cert_types.cc b/net/base/x509_cert_types.cc

index 6beb3ecb21e2c4faa777908688b4eb2ee527c526..11e2338a69b3ecd98122f3848f712210535492d0 100644

--- a/net/base/x509_cert_types.cc

+++ b/net/base/x509_cert_types.cc

@@ -20,7 +20,7 @@ namespace {

// untouched otherwise. Returns the parsed integer.

int ParseIntAndAdvance(const char** field, size_t field_len, bool* ok) {

int result = 0;

- *ok &= base::StringToInt(*field, *field + field_len, &result);

+ *ok &= base::StringToInt(base::StringPiece(*field, field_len), &result);

*field += field_len;

return result;

}

« no previous file with comments | « net/base/net_util.cc ('k') | net/ftp/ftp_ctrl_response_buffer.cc » ('j') | no next file with comments »