chrome/browser/profiles/profile_info_cache.cc - Issue 8921006: Standardize StringToInt{,64} interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_info_cache.cc

Issue 8921006: Standardize StringToInt{,64} interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix uses of StringToInt() in Windows and Mac code. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profiles/profile_info_cache.cc

diff --git a/chrome/browser/profiles/profile_info_cache.cc b/chrome/browser/profiles/profile_info_cache.cc

index 50affc6f08c77e65bfbae6ec0c62b16d2674269a..a33ec9dc105952bc3b076e25bffa481975949a7f 100644

--- a/chrome/browser/profiles/profile_info_cache.cc

+++ b/chrome/browser/profiles/profile_info_cache.cc

@@ -13,6 +13,7 @@

#include "base/rand_util.h"

#include "base/stl_util.h"

#include "base/string_number_conversions.h"

+#include "base/string_piece.h"

#include "base/stringprintf.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

@@ -677,8 +678,9 @@ bool ProfileInfoCache::IsDefaultAvatarIconUrl(const std::string& url,

return false;

int int_value = -1;

- if (base::StringToInt(url.begin() + strlen(kDefaultUrlPrefix),

- url.end(),

+ if (base::StringToInt(base::StringPiece(url.begin() +

+ strlen(kDefaultUrlPrefix),

+ url.end()),

&int_value)) {

if (int_value < 0 ||

int_value >= static_cast<int>(kDefaultAvatarIconsCount))