chrome/common/extensions/extension.cc - Issue 8921006: Standardize StringToInt{,64} interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 8921006: Standardize StringToInt{,64} interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Update formatting and convert HexStringToInt() calls. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 5a67fdf5fbc136177e64ace97331e8efb340778c..67ef96d9e8f5ad5b836220e71738764fcc374bf8 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -17,6 +17,7 @@

#include "base/stl_util.h"

#include "base/string16.h"

#include "base/string_number_conversions.h"

+#include "base/string_piece.h"

#include "base/string_util.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

@@ -79,7 +80,9 @@ const char kDefaultContentSecurityPolicy[] =

static void ConvertHexadecimalToIDAlphabet(std::string* id) {

for (size_t i = 0; i < id->size(); ++i) {

int val;

- if (base::HexStringToInt(id->begin() + i, id->begin() + i + 1, &val))

+ if (base::HexStringToInt(base::StringPiece(id->begin() + i,

+ id->begin() + i + 1),

+ &val))

erikwright (departed) 2011/12/14 04:24:08 need {} around if and else blocks when condition w

(*id)[i] = val + 'a';

else

(*id)[i] = 'a';