Standardize StringToInt{,64} interface.

chrome/browser/sync/test/integration/extensions_helper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/extensions_helper.h"
 
 #include <cstring>
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
+#include "base/string_piece.h"
 #include "base/string_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
 #include "chrome/browser/sync/test/integration/sync_extension_helper.h"
 #include "chrome/common/extensions/extension.h"
 
 using sync_datatype_helper::test;
 
 namespace extensions_helper {
 
@@ skipping 86 matching lines @@
   SyncExtensionHelper::GetInstance()->InstallExtensionsPendingForSync(
       profile, Extension::TYPE_EXTENSION);
 }
 
 std::string CreateFakeExtensionName(int index) {
   return extension_name_prefix + base::IntToString(index);
 }
 
 bool ExtensionNameToIndex(const std::string& name, int* index) {
   if (!StartsWithASCII(name, extension_name_prefix, true) ||
-      !base::StringToInt(name.substr(strlen(extension_name_prefix)), index)) {
+      !base::StringToInt(base::StringPiece(name, strlen(extension_name_prefix)),

[erikwright (departed), 2011/12/16 21:05:50]

Are you sure this works? Looks like it needs to be StringPiece(name.begin() +
strlen(extension_name_prefix), name.end())

+                         index)) {
     LOG(WARNING) << "Unable to convert extension name \"" << name
                  << "\" to index";
     return false;
   }
   return true;
 }
 
 }  // namespace extensions_helper