Issue 8921003: Linux/Gtk: Drawing a focus-ring around the avatar menu items to highlight selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8921003: Linux/Gtk: Drawing a focus-ring around the avatar menu items to highlight selection. (Closed)

Created:
9 years ago by SanjoyPal

Modified:
9 years ago

Reviewers:
sail, Elliot Glaysher

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux/Gtk: Drawing a focus-ring around the avatar menu items to highlight selection. BUG=None. TEST=Click avatar menu and press Tab key to navigate through the menu. Selected menu items should have a focus ring. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114086

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	chrome/browser/ui/gtk/avatar_menu_item_gtk.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/gtk/avatar_menu_item_gtk.cc	View		4 chunks	+18 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

lgtm http://codereview.chromium.org/8921003/diff/1/chrome/browser/ui/gtk/avatar_menu_item_gtk.cc File chrome/browser/ui/gtk/avatar_menu_item_gtk.cc (right): http://codereview.chromium.org/8921003/diff/1/chrome/browser/ui/gtk/avatar_menu_item_gtk.cc#newcode207 chrome/browser/ui/gtk/avatar_menu_item_gtk.cc:207: gtk_widget_get_allocation(widget, &allocation); Thank you for getting this right. ...

9 years ago (2011-12-12 20:48:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/8921003/1

9 years ago (2011-12-12 20:48:36 UTC) #3

Change committed as 114086

Expand Messages | Collapse Messages