Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: client/html/src/SVGSVGElementWrappingImplementation.dart

Issue 8919029: Add a couple useful SVG constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/src/SVGSVGElement.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/src/SVGSVGElementWrappingImplementation.dart
diff --git a/client/html/generated/src/wrapping/_SVGSVGElementWrappingImplementation.dart b/client/html/src/SVGSVGElementWrappingImplementation.dart
similarity index 94%
rename from client/html/generated/src/wrapping/_SVGSVGElementWrappingImplementation.dart
rename to client/html/src/SVGSVGElementWrappingImplementation.dart
index 214705269cd1d6225cd83e34adc6c4c911662451..5dd7a0be9d8372da410f952f322f790339cef2eb 100644
--- a/client/html/generated/src/wrapping/_SVGSVGElementWrappingImplementation.dart
+++ b/client/html/src/SVGSVGElementWrappingImplementation.dart
@@ -2,11 +2,19 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// WARNING: Do not edit - generated code.
-
class SVGSVGElementWrappingImplementation extends SVGElementWrappingImplementation implements SVGSVGElement {
SVGSVGElementWrappingImplementation._wrap(ptr) : super._wrap(ptr) {}
+ factory SVGSVGElementWrappingImplementation() {
+ var el = new SVGElement.tag("svg");
+ // Set the XMLNS so that we can safely embed this tag in an HTML document
+ // and set innerSVG; set version to 1.1 because that's required by the SVG
Jacob 2011/12/13 19:21:54 innerSVG? You mean so that we can simulate innerHT
nweiz 2011/12/13 19:27:57 Done. It turns out (I think) that the implementati
Jacob 2011/12/13 19:29:27 If we can leave out the namespace and still have t
nweiz 2011/12/13 19:41:24 I don't fully understand all the ramifications of
+ // 1.1 spec.
+ el.attributes['xmlns'] = "http://www.w3.org/2000/svg";
+ el.attributes['version'] = 1.1;
+ return el;
+ }
+
String get contentScriptType() { return _ptr.contentScriptType; }
void set contentScriptType(String value) { _ptr.contentScriptType = value; }
« no previous file with comments | « client/html/src/SVGSVGElement.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698