Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 8919021: [Sync] Rename ModelEnumSet to ModelTypeSet (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, kkania, robertshield, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Rename ModelEnumSet to ModelTypeSet Now that the old ModelTypeSet and ModelTypeBitSet are gone, we can rename ModelEnumSet to ModelTypeSet. Conveniently, they're the same number of characters, so this is just a straight rename. Command: git grep -l ModelEnumSet | xargs sed -i '' -e 's/ModelEnumSet/ModelTypeSet/g' BUG=79970 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+724 lines, -724 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/backend_migrator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/backend_migrator.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 20 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/sync/engine/all_status.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/all_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/apply_updates_command.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/cleanup_disabled_types_command.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/cleanup_disabled_types_command_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/download_updates_command.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/get_commit_ids_command.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/get_commit_ids_command.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/engine/model_safe_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/model_safe_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/model_safe_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/nigori_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/nigori_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/nigori_util_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/store_timestamps_command.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_unittest.cc View 26 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/failed_datatypes_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/failed_datatypes_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/sync/glue/data_type_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 13 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/base_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/sync/internal_api/base_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/debug_info_event_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/debug_info_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.h View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 24 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 16 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/sync/internal_api/write_node.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/sync/js/js_mutation_event_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/js_mutation_event_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/chrome_invalidation_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/notifier/chrome_invalidation_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/notifier/chrome_invalidation_client_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/notifier/invalidation_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/invalidation_notifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/non_blocking_invalidation_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/non_blocking_invalidation_notifier.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/notifier/p2p_notifier.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/notifier/p2p_notifier.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/notifier/p2p_notifier_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/notifier/registration_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/registration_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/notifier/registration_manager_unittest.cc View 11 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/sync/notifier/sync_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 13 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 14 chunks +21 lines, -21 lines 0 comments Download
chrome/browser/sync/profile_sync_service_mock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/protocol/sync_protocol_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/session_state.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sessions/session_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/session_state_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/status_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sessions/status_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sync_session.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/sync/sessions/sync_session_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_prefs.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/sync_prefs.cc View 9 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/sync/sync_prefs_unittest.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/directory_change_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_payload_map.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_payload_map.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_payload_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/model_type_test_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_test_util.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/syncable/transaction_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/engine/mock_connection_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/browser/sync/test/engine/test_directory_setter_upper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_errors_test.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/null_directory_change_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/null_directory_change_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/tools/sync_listen_notifications.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/cryptographer.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/util/cryptographer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/util/cryptographer_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+zea for review All changes were completely mechanical (via grep/sed).
9 years ago (2011-12-12 22:43:41 UTC) #1
Nicolas Zea
9 years ago (2011-12-13 01:29:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698