Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
index 7144953387f97c29fed0b2439144fb16db607cca..a2a87445bafe711f475a241e0ff5fc3deda9ca8f 100644
--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc
@@ -23,12 +23,14 @@
#include "chrome/browser/ui/gtk/gtk_theme_service.h"
#include "chrome/browser/ui/gtk/gtk_util.h"
#include "chrome/common/chrome_notification_types.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "ui/base/gtk/gtk_hig_constants.h"
#include "ui/base/l10n/l10n_util.h"
+using content::UserMetricsAction;
+
namespace {
// We basically have a singleton, since a bubble is sort of app-modal. This
@@ -224,7 +226,7 @@ void BookmarkBubbleGtk::OnNameActivate(GtkWidget* widget) {
void BookmarkBubbleGtk::OnFolderChanged(GtkWidget* widget) {
int index = gtk_combo_box_get_active(GTK_COMBO_BOX(folder_combo_));
if (index == folder_combo_model_->GetItemCount() - 1) {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_EditFromCombobox"));
// GTK doesn't handle having the combo box destroyed from the changed
// signal. Since showing the editor also closes the bubble, delay this
@@ -249,7 +251,7 @@ void BookmarkBubbleGtk::OnFolderPopupShown(GtkWidget* widget,
}
void BookmarkBubbleGtk::OnEditClicked(GtkWidget* widget) {
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
ShowEditor();
}
@@ -258,7 +260,7 @@ void BookmarkBubbleGtk::OnCloseClicked(GtkWidget* widget) {
}
void BookmarkBubbleGtk::OnRemoveClicked(GtkWidget* widget) {
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
apply_edits_ = false;
remove_bookmark_ = true;
@@ -276,7 +278,7 @@ void BookmarkBubbleGtk::ApplyEdits() {
if (new_title != node->GetTitle()) {
model_->SetTitle(node, new_title);
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
}
@@ -286,7 +288,7 @@ void BookmarkBubbleGtk::ApplyEdits() {
if (index < folder_combo_model_->GetItemCount() - 1) {
const BookmarkNode* new_parent = folder_combo_model_->GetNodeAt(index);
if (new_parent != node->parent()) {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeParent"));
model_->Move(node, new_parent, new_parent->child_count());
}
« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc ('k') | chrome/browser/ui/gtk/browser_toolbar_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698