Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_service.cc
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc
index c4a629165b52105220466beba9c8a4045308f5c0..e5eb407d86b3e4c51ee0b2ebc87bace1b420f3db 100644
--- a/chrome/browser/themes/theme_service.cc
+++ b/chrome/browser/themes/theme_service.cc
@@ -14,8 +14,8 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/pref_names.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/theme_resources.h"
#include "grit/theme_resources_standard.h"
#include "grit/ui_resources.h"
@@ -26,6 +26,7 @@
#endif
using content::BrowserThread;
+using content::UserMetricsAction;
// Strings used in alignment properties.
const char* ThemeService::kAlignmentTop = "top";
@@ -327,7 +328,7 @@ void ThemeService::SetTheme(const Extension* extension) {
SaveThemeID(extension->id());
NotifyThemeChanged();
- UserMetrics::RecordAction(UserMetricsAction("Themes_Installed"));
+ content::RecordAction(UserMetricsAction("Themes_Installed"));
}
void ThemeService::RemoveUnusedThemes() {
@@ -352,7 +353,7 @@ void ThemeService::RemoveUnusedThemes() {
void ThemeService::UseDefaultTheme() {
ClearAllThemeData();
NotifyThemeChanged();
- UserMetrics::RecordAction(UserMetricsAction("Themes_Reset"));
+ content::RecordAction(UserMetricsAction("Themes_Reset"));
}
void ThemeService::SetNativeTheme() {
@@ -585,7 +586,7 @@ void ThemeService::LoadThemePrefs() {
}
if (loaded_pack) {
- UserMetrics::RecordAction(UserMetricsAction("Themes.Loaded"));
+ content::RecordAction(UserMetricsAction("Themes.Loaded"));
} else {
// TODO(erg): We need to pop up a dialog informing the user that their
// theme is being migrated.
@@ -596,11 +597,11 @@ void ThemeService::LoadThemePrefs() {
if (extension) {
DLOG(ERROR) << "Migrating theme";
BuildFromExtension(extension);
- UserMetrics::RecordAction(UserMetricsAction("Themes.Migrated"));
+ content::RecordAction(UserMetricsAction("Themes.Migrated"));
} else {
DLOG(ERROR) << "Theme is mysteriously gone.";
ClearAllThemeData();
- UserMetrics::RecordAction(UserMetricsAction("Themes.Gone"));
+ content::RecordAction(UserMetricsAction("Themes.Gone"));
}
}
}
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698