Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: chrome/browser/chromeos/status/input_method_menu.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/chromeos/system_key_event_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/status/input_method_menu.cc
diff --git a/chrome/browser/chromeos/status/input_method_menu.cc b/chrome/browser/chromeos/status/input_method_menu.cc
index 4ac4b88f93dd9399c026861cda27708e1b63506b..c1012d742c224b7aafde783c0558391c7f469648 100644
--- a/chrome/browser/chromeos/status/input_method_menu.cc
+++ b/chrome/browser/chromeos/status/input_method_menu.cc
@@ -18,8 +18,8 @@
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/pref_names.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -30,6 +30,8 @@
#include "ui/views/controls/menu/submenu_view.h"
#include "ui/views/widget/widget.h"
+using content::UserMetricsAction;
+
// The language menu consists of 3 parts (in this order):
//
// (1) input method names. The size of the list is always >= 1.
@@ -354,7 +356,7 @@ void InputMethodMenu::ActivatedAt(int index) {
= input_method_descriptors_->at(index);
InputMethodManager::GetInstance()->ChangeInputMethod(
input_method.id());
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("LanguageMenuButton_InputMethodChanged"));
return;
}
@@ -488,7 +490,7 @@ void InputMethodMenu::FirstObserverIsAdded(InputMethodManager* manager) {
}
void InputMethodMenu::PrepareForMenuOpen() {
- UserMetrics::RecordAction(UserMetricsAction("LanguageMenuButton_Open"));
+ content::RecordAction(UserMetricsAction("LanguageMenuButton_Open"));
PrepareMenuModel();
}
« no previous file with comments | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/chromeos/system_key_event_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698