Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4717)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 54783b465229a8a80e6bc371f72d8e427bfd5cd0..814b019a0f4d27290500dd26278419bcb9f1673c 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -63,10 +63,10 @@
#include "chrome/common/url_constants.h"
#include "content/browser/download/download_manager.h"
#include "content/browser/tab_contents/tab_contents.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "net/base/net_util.h"
@@ -75,6 +75,7 @@
#include "ui/base/l10n/l10n_util_mac.h"
using content::BrowserThread;
+using content::UserMetricsAction;
// 10.6 adds a public API for the Spotlight-backed search menu item in the Help
// menu. Provide the declaration so it can be called below when building with
@@ -824,7 +825,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
break;
}
case IDC_SHOW_BOOKMARK_MANAGER:
- UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"));
+ content::RecordAction(UserMetricsAction("ShowBookmarkManager"));
if (Browser* browser = ActivateBrowser(lastProfile)) {
// Open a bookmark manager tab.
browser->OpenBookmarkManager();
@@ -874,7 +875,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
ProfileSyncService::START_FROM_WRENCH);
break;
case IDC_TASK_MANAGER:
- UserMetrics::RecordAction(UserMetricsAction("TaskManager"));
+ content::RecordAction(UserMetricsAction("TaskManager"));
TaskManagerMac::Show(false);
break;
case IDC_OPTIONS:
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698