Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/public/browser/user_metrics.h

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/content_browser.gypi ('K') | « content/content_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/user_metrics.h
diff --git a/content/browser/user_metrics.h b/content/public/browser/user_metrics.h
similarity index 86%
copy from content/browser/user_metrics.h
copy to content/public/browser/user_metrics.h
index ae04af3d49aa6220c2dee4f09835f2e72d3ce7b3..8e9e4d45eb580663f1e5c60515717a84a75d74de 100644
--- a/content/browser/user_metrics.h
+++ b/content/public/browser/user_metrics.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_USER_METRICS_H_
-#define CONTENT_BROWSER_USER_METRICS_H_
+#ifndef CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
+#define CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
#pragma once
#include <string>
@@ -12,6 +12,10 @@
// This module provides some helper functions for logging actions tracked by
// the user metrics system.
+//
+// Note that we do not wrap this in the content namespace to avoid
+// making it more difficult to comply with the single-line requirement
+// discussed for UserMetrics::RecordAction below.
// UserMetricsAction exist purely to standardize on the paramters passed to
@@ -50,10 +54,6 @@ class CONTENT_EXPORT UserMetrics {
// you need to also update the rules for extracting known actions in
// chrome/tools/extract_actions.py.
static void RecordComputedAction(const std::string& action);
-
- private:
- static void Record(const char *action);
- static void CallRecordOnUI(const std::string& action);
};
-#endif // CONTENT_BROWSER_USER_METRICS_H_
+#endif // CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
« content/content_browser.gypi ('K') | « content/content_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698