Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/public/browser/user_metrics.h

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/user_metrics.cc ('K') | « content/content_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/user_metrics.h
diff --git a/content/public/browser/user_metrics.h b/content/public/browser/user_metrics.h
new file mode 100644
index 0000000000000000000000000000000000000000..7bbc3bf4ab38ffba9c171972a84024c2591b19e4
--- /dev/null
+++ b/content/public/browser/user_metrics.h
@@ -0,0 +1,56 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
jam 2011/12/14 01:18:38 nit: is this file moved or copied? the svn history
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
+#define CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
+#pragma once
+
+#include <string>
+
+#include "content/common/content_export.h"
+
+namespace content {
+
+// This module provides some helper functions for logging actions tracked by
+// the user metrics system.
+
+
+// UserMetricsAction exist purely to standardize on the paramters passed to
+// UserMetrics. That way, our toolset can scan the sourcecode reliable for
+// constructors and extract the associated string constants
+struct UserMetricsAction {
+ const char* str_;
+ explicit UserMetricsAction(const char* str) : str_(str) {}
+};
+
+// Record that the user performed an action.
+// "Action" here means a user-generated event:
+// good: "Reload", "CloseTab", and "IMEInvoked"
+// not good: "SSLDialogShown", "PageLoaded", "DiskFull"
+// We use this to gather anonymized information about how users are
+// interacting with the browser.
+// WARNING: In calls to this function, UserMetricsAction and a
+// string literal parameter must be on the same line, e.g.
+// content::RecordAction(
+// content::UserMetricsAction("my extremely long action name"));
+// because otherwise our processing scripts won't pick up on new actions.
+//
+// Once a new recorded action is added, run chrome/tools/extract_actions.py
+// to generate a new mapping of [action hashes -> metric names] and send it
+// out for review to be updated.
+//
+// For more complicated situations (like when there are many different
+// possible actions), see RecordComputedAction.
+CONTENT_EXPORT void RecordAction(const UserMetricsAction& action);
+
+// This function has identical input and behavior to RecordAction, but is
+// not automatically found by the action-processing scripts. It can be used
+// when it's a pain to enumerate all possible actions, but if you use this
+// you need to also update the rules for extracting known actions in
+// chrome/tools/extract_actions.py.
+CONTENT_EXPORT void RecordComputedAction(const std::string& action);
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_BROWSER_USER_METRICS_H_
« content/browser/user_metrics.cc ('K') | « content/content_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698