Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents.cc
diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc
index 4324339ce563ca489757c39e17b723729abac8f1..8fb439747a17228d153ad448f096844f69cd29d4 100644
--- a/content/browser/tab_contents/tab_contents.cc
+++ b/content/browser/tab_contents/tab_contents.cc
@@ -37,13 +37,13 @@
#include "content/browser/tab_contents/tab_contents_observer.h"
#include "content/browser/tab_contents/tab_contents_view.h"
#include "content/browser/tab_contents/title_updated_details.h"
-#include "content/browser/user_metrics.h"
#include "content/browser/webui/web_ui_factory.h"
#include "content/common/intents_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/devtools_agent_host_registry.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/common/content_constants.h"
#include "content/public/common/content_restriction.h"
@@ -110,6 +110,7 @@
using content::DevToolsAgentHost;
using content::DevToolsAgentHostRegistry;
using content::DevToolsManagerImpl;
+using content::UserMetricsAction;
namespace {
@@ -327,7 +328,7 @@ bool TabContents::OnMessageReceived(const IPC::Message& message) {
IPC_END_MESSAGE_MAP_EX()
if (!message_is_ok) {
- UserMetrics::RecordAction(UserMetricsAction("BadMessageTerminate_RVD"));
+ content::RecordAction(UserMetricsAction("BadMessageTerminate_RVD"));
GetRenderProcessHost()->ReceivedBadMessage();
}
@@ -1072,7 +1073,7 @@ void TabContents::OnDidLoadResourceFromMemoryCache(
}
void TabContents::OnDidDisplayInsecureContent() {
- UserMetrics::RecordAction(UserMetricsAction("SSL.DisplayedInsecureContent"));
+ content::RecordAction(UserMetricsAction("SSL.DisplayedInsecureContent"));
displayed_insecure_content_ = true;
SSLManager::NotifySSLInternalStateChanged(&controller());
}
@@ -1081,9 +1082,9 @@ void TabContents::OnDidRunInsecureContent(
const std::string& security_origin, const GURL& target_url) {
LOG(INFO) << security_origin << " ran insecure content from "
<< target_url.possibly_invalid_spec();
- UserMetrics::RecordAction(UserMetricsAction("SSL.RanInsecureContent"));
+ content::RecordAction(UserMetricsAction("SSL.RanInsecureContent"));
if (EndsWith(security_origin, kDotGoogleDotCom, false)) {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("SSL.RanInsecureContentGoogle"));
}
controller_.ssl_manager()->DidRunInsecureContent(security_origin);

Powered by Google App Engine
This is Rietveld 408576698