Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 1f9ff8d5d4c79cf36cbd7b5aeed3db04c1d66fa5..4e074e798227f1f9ed60a43788f86637a4d3c7f5 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -75,13 +75,13 @@
#include "content/browser/resolve_proxy_msg_helper.h"
#include "content/browser/speech/speech_input_dispatcher_host.h"
#include "content/browser/trace_message_filter.h"
-#include "content/browser/user_metrics.h"
#include "content/browser/webui/web_ui_factory.h"
#include "content/browser/worker_host/worker_message_filter.h"
#include "content/common/child_process_host_impl.h"
#include "content/common/child_process_messages.h"
#include "content/common/gpu/gpu_messages.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "content/common/resource_messages.h"
#include "content/common/view_messages.h"
#include "content/public/browser/content_browser_client.h"
@@ -114,6 +114,7 @@
using content::BrowserThread;
using content::ChildProcessHost;
using content::ChildProcessHostImpl;
+using content::UserMetricsAction;
// This class creates the IO thread for the renderer when running in
// single-process mode. It's not used in multi-process mode.
@@ -919,7 +920,7 @@ bool RenderProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {
// The message had a handler, but its de-serialization failed.
// We consider this a capital crime. Kill the renderer if we have one.
LOG(ERROR) << "bad message " << msg.type() << " terminating renderer.";
- UserMetrics::RecordAction(UserMetricsAction("BadMessageTerminate_BRPH"));
+ content::RecordAction(UserMetricsAction("BadMessageTerminate_BRPH"));
ReceivedBadMessage();
}
return true;
@@ -1316,7 +1317,7 @@ void RenderProcessHostImpl::OnProcessLaunched() {
void RenderProcessHostImpl::OnUserMetricsRecordAction(
const std::string& action) {
- UserMetrics::RecordComputedAction(action);
+ content::RecordComputedAction(action);
}
void RenderProcessHostImpl::OnRevealFolderInOS(const FilePath& path) {

Powered by Google App Engine
This is Rietveld 408576698