chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | content/browser/user_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index 3e5fc17364ec973e5402736410e8f2bf3112402a..ddeabb62062ffb13556cd3ba8127be8e91620a7c 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -39,9 +39,9 @@

#include "content/browser/renderer_host/render_widget_host_view.h"

#include "content/browser/tab_contents/page_navigator.h"

#include "content/browser/tab_contents/tab_contents.h"

-#include "content/browser/user_metrics.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

+#include "content/public/browser/user_metrics.h"

#include "content/public/common/page_transition_types.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

@@ -62,6 +62,7 @@

#include "ui/views/widget/tooltip_manager.h"

#include "ui/views/widget/widget.h"

+using content::UserMetricsAction;

using views::CustomButton;

using views::DropTargetEvent;

using views::MenuButton;

@@ -926,7 +927,7 @@ void BookmarkBarView::BookmarkNodeFaviconChanged(BookmarkModel* model,

void BookmarkBarView::WriteDragDataForView(View* sender,

const gfx::Point& press_pt,

ui::OSExchangeData* data) {

- UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_DragButton"));

+ content::RecordAction(UserMetricsAction("BookmarkBar_DragButton"));

for (int i = 0; i < GetBookmarkButtonCount(); ++i) {

if (sender == GetBookmarkButton(i)) {

@@ -1037,7 +1038,7 @@ void BookmarkBarView::ButtonPressed(views::Button* sender,

bookmark_utils::RecordBookmarkLaunch(IsDetached() ?

bookmark_utils::LAUNCH_DETACHED_BAR :

bookmark_utils::LAUNCH_ATTACHED_BAR);

- UserMetrics::RecordAction(UserMetricsAction("ClickedBookmarkBarURLButton"));

+ content::RecordAction(UserMetricsAction("ClickedBookmarkBarURLButton"));

}

void BookmarkBarView::ShowContextMenuForView(View* source,