chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm ('k') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('j') | content/browser/user_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index a85468926bae3b3e81cebb31758778b85167999e..8e955360283ffa7f25b7a4dac2144ab171743d67 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -13,9 +13,11 @@

#include "chrome/browser/ui/browser.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"

#include "chrome/browser/ui/cocoa/event_utils.h"

-#include "content/browser/user_metrics.h"

+#include "content/public/browser/user_metrics.h"

#include "ui/base/text/text_elider.h"

+using content::UserMetricsAction;

namespace {

// Menus more than this many pixels wide will get trimmed

@@ -116,11 +118,11 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

disposition);

if (disposition == NEW_FOREGROUND_TAB) {

- UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarks"));

+ content::RecordAction(UserMetricsAction("OpenAllBookmarks"));

} else if (disposition == NEW_WINDOW) {

- UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));

+ content::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));

} else {

- UserMetrics::RecordAction(

+ content::RecordAction(

UserMetricsAction("OpenAllBookmarksIncognitoWindow"));

}