Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index caf3684562fbf306dbeffff35ffd86d076a75c4a..b2c2959f4352703296cc4c20b40b495e711c0a26 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -65,8 +65,8 @@
#include "content/browser/tab_contents/navigation_details.h"
#include "content/browser/tab_contents/navigation_entry.h"
#include "content/browser/tab_contents/tab_contents.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "content/public/common/content_restriction.h"
#include "grit/generated_resources.h"
#include "net/base/escape.h"
@@ -82,6 +82,7 @@
#include "chrome/browser/extensions/file_manager_util.h"
#endif
+using content::UserMetricsAction;
using WebKit::WebContextMenuData;
using WebKit::WebMediaPlayerAction;
using WebKit::WebURL;
@@ -1374,7 +1375,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
if (handlers.empty()) {
return;
}
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("RegisterProtocolHandler.ContextMenu_Open"));
int handlerIndex = id - IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST;
WindowOpenDisposition disposition =
@@ -1458,9 +1459,9 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
case IDC_CONTENT_CONTEXT_PLAYPAUSE: {
bool play = !!(params_.media_flags & WebContextMenuData::MediaPaused);
if (play) {
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Play"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Play"));
} else {
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Pause"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Pause"));
}
MediaPlayerActionAt(gfx::Point(params_.x, params_.y),
WebMediaPlayerAction(
@@ -1471,9 +1472,9 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
case IDC_CONTENT_CONTEXT_MUTE: {
bool mute = !(params_.media_flags & WebContextMenuData::MediaMuted);
if (mute) {
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Mute"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Mute"));
} else {
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Unmute"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Unmute"));
}
MediaPlayerActionAt(gfx::Point(params_.x, params_.y),
WebMediaPlayerAction(
@@ -1482,7 +1483,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
}
case IDC_CONTENT_CONTEXT_LOOP:
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Loop"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Loop"));
MediaPlayerActionAt(gfx::Point(params_.x, params_.y),
WebMediaPlayerAction(
WebMediaPlayerAction::Loop,
@@ -1490,7 +1491,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
break;
case IDC_CONTENT_CONTEXT_CONTROLS:
- UserMetrics::RecordAction(UserMetricsAction("MediaContextMenu_Controls"));
+ content::RecordAction(UserMetricsAction("MediaContextMenu_Controls"));
MediaPlayerActionAt(
gfx::Point(params_.x, params_.y),
WebMediaPlayerAction(
@@ -1677,7 +1678,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
break;
#endif // OS_MACOSX
case IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS: {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("RegisterProtocolHandler.ContextMenu_Settings"));
WindowOpenDisposition disposition =
ForceNewTabDispositionFromEventFlags(event_flags);
@@ -1829,7 +1830,7 @@ void RenderViewContextMenu::CopyImageAt(int x, int y) {
}
void RenderViewContextMenu::Inspect(int x, int y) {
- UserMetrics::RecordAction(UserMetricsAction("DevTools_InspectElement"));
+ content::RecordAction(UserMetricsAction("DevTools_InspectElement"));
DevToolsWindow::InspectElement(
source_tab_contents_->render_view_host(), x, y);
}

Powered by Google App Engine
This is Rietveld 408576698