Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: chrome/browser/chromeos/login/login_performer.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/login_performer.cc
diff --git a/chrome/browser/chromeos/login/login_performer.cc b/chrome/browser/chromeos/login/login_performer.cc
index 9da3498abae1664e0b4057d9a2903072af78229e..083624929c2379c8ae1244a5c4d19335f8b7a901 100644
--- a/chrome/browser/chromeos/login/login_performer.cc
+++ b/chrome/browser/chromeos/login/login_performer.cc
@@ -26,10 +26,10 @@
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "net/base/cookie_monster.h"
#include "net/base/cookie_store.h"
@@ -39,6 +39,7 @@
#include "ui/base/resource/resource_bundle.h"
using content::BrowserThread;
+using content::UserMetricsAction;
namespace chromeos {
@@ -72,7 +73,7 @@ LoginPerformer::~LoginPerformer() {
// LoginPerformer, LoginStatusConsumer implementation:
void LoginPerformer::OnLoginFailure(const LoginFailure& failure) {
- UserMetrics::RecordAction(UserMetricsAction("Login_Failure"));
+ content::RecordAction(UserMetricsAction("Login_Failure"));
UMA_HISTOGRAM_ENUMERATION("Login.FailureReason", failure.reason(),
LoginFailure::NUM_FAILURE_REASONS);
@@ -126,7 +127,7 @@ void LoginPerformer::OnLoginSuccess(
const GaiaAuthConsumer::ClientLoginResult& credentials,
bool pending_requests,
bool using_oauth) {
- UserMetrics::RecordAction(UserMetricsAction("Login_Success"));
+ content::RecordAction(UserMetricsAction("Login_Success"));
// 0 - Login success offline and online. It's a new user. or it's an
// existing user and offline auth took longer than online auth.
// 1 - Login success offline only. It's an existing user login.
@@ -201,7 +202,7 @@ void LoginPerformer::OnProfileCreated(
}
void LoginPerformer::OnOffTheRecordLoginSuccess() {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("Login_GuestLoginSuccess"));
if (delegate_)

Powered by Google App Engine
This is Rietveld 408576698