Split UserMetrics into API vs. implementation. Move API to content/public.

chrome/tools/extract_actions.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
 UserMetrics functions, extracting actions and warning on improper calls,
@@ skipping 11 matching lines @@
 
 import hashlib
 from HTMLParser import HTMLParser
 import os
 import re
 import sys
 
 sys.path.insert(1, os.path.join(sys.path[0], '..', '..', 'tools', 'python'))
 from google import path_utils
 
-# Files that are known to use UserMetrics::RecordComputedAction(), which means
+# Files that are known to use content::RecordComputedAction(), which means
 # they require special handling code in this script.
 # To add a new file, add it to this list and add the appropriate logic to
 # generate the known actions to AddComputedActions() below.
 KNOWN_COMPUTED_USERS = (
   'back_forward_menu_model.cc',
   'options_page_view.cc',
   'render_view_host.cc',  # called using webkit identifiers
   'user_metrics.cc',  # method definition
   'new_tab_ui.cc',  # most visited clicks 1-9
   'extension_metrics_module.cc', # extensions hook for user metrics
@@ skipping 197 matching lines @@
   Arguments:
     path: path to the file
     actions: set of actions to add to
   """
   global number_of_files_total
   number_of_files_total = number_of_files_total + 1
   # we look for the UserMetricsAction structure constructor
   # this should be on one line
   action_re = re.compile(r'[^a-zA-Z]UserMetricsAction\("([^"]*)')
   malformed_action_re = re.compile(r'[^a-zA-Z]UserMetricsAction\([^"]')
-  computed_action_re = re.compile(r'UserMetrics::RecordComputedAction')
+  computed_action_re = re.compile(r'RecordComputedAction')
   line_number = 0
   for line in open(path):
     line_number = line_number + 1
     match = action_re.search(line)
     if match:  # Plain call to RecordAction
       actions.add(match.group(1))
     elif malformed_action_re.search(line):
       # Warn if this line is using RecordAction incorrectly.
       print >>sys.stderr, ('WARNING: %s has malformed call to RecordAction'
                            ' at %d' % (path, line_number))
@@ skipping 43 matching lines @@
     else:
       self.actions.add(attrs['metric'])
 
 def GrepForWebUIActions(path, actions):
   """Grep a WebUI source file for elements with associated metrics.
 
   Arguments:
     path: path to the file
     actions: set of actions to add to
   """
-  parser = WebUIActionsParser(actions)
-  parser.feed(open(path).read())
-  parser.close()
+  try:
+    parser = WebUIActionsParser(actions)
+    parser.feed(open(path).read())
+  except Exception, e:
+    print "Error encountered for path %s" % path
+    raise e
+  finally:
+    parser.close()
 
 def WalkDirectory(root_path, actions, extensions, callback):
   for path, dirs, files in os.walk(root_path):
     if '.svn' in dirs:
       dirs.remove('.svn')
+    if '.git' in dirs:
+      dirs.remove('.git')
     for file in files:
       ext = os.path.splitext(file)[1]
       if ext in extensions:
         callback(os.path.join(path, file), actions)
 
 def GrepForRendererActions(path, actions):
   """Grep a source file for calls to RenderThread::RecordUserMetrics.
 
   Arguments:
     path: path to the file
@@ skipping 107 matching lines @@
     else:
       print action
 
   if hash_output:
     print "Done. Do not forget to add chromeactions.txt to your changelist"
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))