Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h" 5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"
6 6
7 #include "base/sys_string_conversions.h" 7 #include "base/sys_string_conversions.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" // IDC_BOOKMARK_MENU 9 #include "chrome/app/chrome_command_ids.h" // IDC_BOOKMARK_MENU
10 #import "chrome/browser/app_controller_mac.h" 10 #import "chrome/browser/app_controller_mac.h"
11 #include "chrome/browser/bookmarks/bookmark_model.h" 11 #include "chrome/browser/bookmarks/bookmark_model.h"
12 #include "chrome/browser/bookmarks/bookmark_utils.h" 12 #include "chrome/browser/bookmarks/bookmark_utils.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h" 14 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"
15 #include "chrome/browser/ui/cocoa/event_utils.h" 15 #include "chrome/browser/ui/cocoa/event_utils.h"
16 #include "content/browser/user_metrics.h" 16 #include "content/public/browser/user_metrics.h"
17 #include "ui/base/text/text_elider.h" 17 #include "ui/base/text/text_elider.h"
18 18
19 using content::UserMetricsAction;
20
19 namespace { 21 namespace {
20 22
21 // Menus more than this many pixels wide will get trimmed 23 // Menus more than this many pixels wide will get trimmed
22 // TODO(jrg): ask UI dudes what a good value is. 24 // TODO(jrg): ask UI dudes what a good value is.
23 const NSUInteger kMaximumMenuPixelsWide = 300; 25 const NSUInteger kMaximumMenuPixelsWide = 300;
24 26
25 } 27 }
26 28
27 @implementation BookmarkMenuCocoaController 29 @implementation BookmarkMenuCocoaController
28 30
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 browser = Browser::Create(bridge_->GetProfile()); 111 browser = Browser::Create(bridge_->GetProfile());
110 DCHECK(browser); 112 DCHECK(browser);
111 113
112 if (!node || !browser) 114 if (!node || !browser)
113 return; // shouldn't be reached 115 return; // shouldn't be reached
114 116
115 bookmark_utils::OpenAll(NULL, browser->profile(), browser, node, 117 bookmark_utils::OpenAll(NULL, browser->profile(), browser, node,
116 disposition); 118 disposition);
117 119
118 if (disposition == NEW_FOREGROUND_TAB) { 120 if (disposition == NEW_FOREGROUND_TAB) {
119 UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarks")); 121 content::RecordAction(UserMetricsAction("OpenAllBookmarks"));
120 } else if (disposition == NEW_WINDOW) { 122 } else if (disposition == NEW_WINDOW) {
121 UserMetrics::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow")); 123 content::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));
122 } else { 124 } else {
123 UserMetrics::RecordAction( 125 content::RecordAction(
124 UserMetricsAction("OpenAllBookmarksIncognitoWindow")); 126 UserMetricsAction("OpenAllBookmarksIncognitoWindow"));
125 } 127 }
126 } 128 }
127 129
128 - (IBAction)openBookmarkMenuItem:(id)sender { 130 - (IBAction)openBookmarkMenuItem:(id)sender {
129 NSInteger tag = [sender tag]; 131 NSInteger tag = [sender tag];
130 int identifier = tag; 132 int identifier = tag;
131 const BookmarkNode* node = [self nodeForIdentifier:identifier]; 133 const BookmarkNode* node = [self nodeForIdentifier:identifier];
132 DCHECK(node); 134 DCHECK(node);
133 if (!node) 135 if (!node)
134 return; // shouldn't be reached 136 return; // shouldn't be reached
135 137
136 [self openURLForNode:node]; 138 [self openURLForNode:node];
137 } 139 }
138 140
139 - (IBAction)openAllBookmarks:(id)sender { 141 - (IBAction)openAllBookmarks:(id)sender {
140 [self openAll:[sender tag] withDisposition:NEW_FOREGROUND_TAB]; 142 [self openAll:[sender tag] withDisposition:NEW_FOREGROUND_TAB];
141 } 143 }
142 144
143 - (IBAction)openAllBookmarksNewWindow:(id)sender { 145 - (IBAction)openAllBookmarksNewWindow:(id)sender {
144 [self openAll:[sender tag] withDisposition:NEW_WINDOW]; 146 [self openAll:[sender tag] withDisposition:NEW_WINDOW];
145 } 147 }
146 148
147 - (IBAction)openAllBookmarksIncognitoWindow:(id)sender { 149 - (IBAction)openAllBookmarksIncognitoWindow:(id)sender {
148 [self openAll:[sender tag] withDisposition:OFF_THE_RECORD]; 150 [self openAll:[sender tag] withDisposition:OFF_THE_RECORD];
149 } 151 }
150 152
151 @end // BookmarkMenuCocoaController 153 @end // BookmarkMenuCocoaController
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698