Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/password_manager/password_manager.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/first_run/first_run_win.cc ('k') | chrome/browser/plugin_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_manager.h" 5 #include "chrome/browser/password_manager/password_manager.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/password_manager/password_form_manager.h" 12 #include "chrome/browser/password_manager/password_form_manager.h"
13 #include "chrome/browser/password_manager/password_manager_delegate.h" 13 #include "chrome/browser/password_manager/password_manager_delegate.h"
14 #include "chrome/browser/prefs/pref_service.h" 14 #include "chrome/browser/prefs/pref_service.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/common/autofill_messages.h" 16 #include "chrome/common/autofill_messages.h"
17 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
18 #include "content/browser/user_metrics.h" 18 #include "content/public/browser/user_metrics.h"
19 #include "content/public/common/frame_navigate_params.h" 19 #include "content/public/common/frame_navigate_params.h"
20 #include "grit/generated_resources.h" 20 #include "grit/generated_resources.h"
21 21
22 using content::UserMetricsAction;
22 using webkit_glue::PasswordForm; 23 using webkit_glue::PasswordForm;
23 using webkit_glue::PasswordFormMap; 24 using webkit_glue::PasswordFormMap;
24 25
25 // static 26 // static
26 void PasswordManager::RegisterUserPrefs(PrefService* prefs) { 27 void PasswordManager::RegisterUserPrefs(PrefService* prefs) {
27 prefs->RegisterBooleanPref(prefs::kPasswordManagerEnabled, 28 prefs->RegisterBooleanPref(prefs::kPasswordManagerEnabled,
28 true, 29 true,
29 PrefService::SYNCABLE_PREF); 30 PrefService::SYNCABLE_PREF);
30 prefs->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords, 31 prefs->RegisterBooleanPref(prefs::kPasswordManagerAllowShowPasswords,
31 true, 32 true,
(...skipping 10 matching lines...) Expand all
42 static base::PlatformThreadId initial_thread_id = 43 static base::PlatformThreadId initial_thread_id =
43 base::PlatformThread::CurrentId(); 44 base::PlatformThread::CurrentId();
44 DCHECK(initial_thread_id == base::PlatformThread::CurrentId()); 45 DCHECK(initial_thread_id == base::PlatformThread::CurrentId());
45 46
46 static bool ran_once = false; 47 static bool ran_once = false;
47 if (ran_once) 48 if (ran_once)
48 return; 49 return;
49 ran_once = true; 50 ran_once = true;
50 51
51 if (password_manager_enabled) 52 if (password_manager_enabled)
52 UserMetrics::RecordAction(UserMetricsAction("PasswordManager_Enabled")); 53 content::RecordAction(UserMetricsAction("PasswordManager_Enabled"));
53 else 54 else
54 UserMetrics::RecordAction(UserMetricsAction("PasswordManager_Disabled")); 55 content::RecordAction(UserMetricsAction("PasswordManager_Disabled"));
55 } 56 }
56 57
57 PasswordManager::PasswordManager(TabContents* tab_contents, 58 PasswordManager::PasswordManager(TabContents* tab_contents,
58 PasswordManagerDelegate* delegate) 59 PasswordManagerDelegate* delegate)
59 : TabContentsObserver(tab_contents), 60 : TabContentsObserver(tab_contents),
60 login_managers_deleter_(&pending_login_managers_), 61 login_managers_deleter_(&pending_login_managers_),
61 delegate_(delegate), 62 delegate_(delegate),
62 observer_(NULL) { 63 observer_(NULL) {
63 DCHECK(delegate_); 64 DCHECK(delegate_);
64 password_manager_enabled_.Init(prefs::kPasswordManagerEnabled, 65 password_manager_enabled_.Init(prefs::kPasswordManagerEnabled,
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 delegate_->FillPasswordForm(fill_data); 235 delegate_->FillPasswordForm(fill_data);
235 return; 236 return;
236 } 237 }
237 default: 238 default:
238 if (observer_) { 239 if (observer_) {
239 observer_->OnAutofillDataAvailable(preferred_match->username_value, 240 observer_->OnAutofillDataAvailable(preferred_match->username_value,
240 preferred_match->password_value); 241 preferred_match->password_value);
241 } 242 }
242 } 243 }
243 } 244 }
OLDNEW
« no previous file with comments | « chrome/browser/first_run/first_run_win.cc ('k') | chrome/browser/plugin_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698