Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 8919016: base::Bind: Make use of partial currying to get rid of a helper class. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
ajwong, awong
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

base::Bind: Make use of partial currying to get rid of a helper class. BUG=none TEST=none R=ajwong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114122

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -36 lines) Patch
M base/callback.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/callback.h.pump View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_benchmarking_message_filter.cc View 1 5 chunks +15 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years ago (2011-12-12 21:55:06 UTC) #1
awong
LGTM http://codereview.chromium.org/8919016/diff/1/base/callback.h File base/callback.h (right): http://codereview.chromium.org/8919016/diff/1/base/callback.h#newcode127 base/callback.h:127: // 3) The arguments wrappers (e.g., Unretained() and ...
9 years ago (2011-12-12 21:56:56 UTC) #2
James Hawkins
http://codereview.chromium.org/8919016/diff/1/base/callback.h File base/callback.h (right): http://codereview.chromium.org/8919016/diff/1/base/callback.h#newcode127 base/callback.h:127: // 3) The arguments wrappers (e.g., Unretained() and ConstRef()). ...
9 years ago (2011-12-12 22:23:28 UTC) #3
awong
9 years ago (2011-12-12 22:39:04 UTC) #4
LGTM++

Powered by Google App Engine
This is Rietveld 408576698