Allow bypassing of certificate issues even in pinned domains.

Allow bypassing of certificate issues even in pinned domains.

At least we got rid of the button!

BUG=105582
TEST=Go to https://latest.foo.appspot.com and get an interstitial with no "Proceed" button. Type "proceed" in the page and expect it to continue to load.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114464

[agl, 2011-12-12 19:35:07]

(See email discussion about why.)

[wtc, 2011-12-12 21:52:43]

Patch Set 1 LGTM.

Please reference the original bug
  BUG=105582
in the CL's commit message.

http://codereview.chromium.org/8919007/diff/1/chrome/browser/resources/ssl_er...
File chrome/browser/resources/ssl_error.html (right):

http://codereview.chromium.org/8919007/diff/1/chrome/browser/resources/ssl_er...
chrome/browser/resources/ssl_error.html:99: var sequence = "skip";

Ideally the magic sequence should be "proceed" to match the
"Proceed" button.  I guess you chose "skip" because it's easier
to type?

[agl, 2011-12-12 22:10:55]

http://codereview.chromium.org/8919007/diff/1/chrome/browser/resources/ssl_er...
File chrome/browser/resources/ssl_error.html (right):

http://codereview.chromium.org/8919007/diff/1/chrome/browser/resources/ssl_er...
chrome/browser/resources/ssl_error.html:99: var sequence = "skip";
On 2011/12/12 21:52:44, wtc wrote:
> 
> Ideally the magic sequence should be "proceed" to match the
> "Proceed" button.  I guess you chose "skip" because it's easier
> to type?

Done.

[commit-bot: I haz the power, 2011-12-12 22:12:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/8919007/4002

[commit-bot: I haz the power, 2011-12-12 22:12:19]

Presubmit check for 8919007-4002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/resources/ssl_error.html

Presubmit checks took 1.5s to calculate.

[agl, 2011-12-12 22:17:47]

Switching reviewer to estade for OWNERS approval.

[agl, 2011-12-14 17:12:41]

Switching to jhawkins for OWNERS approval.

[James Hawkins, 2011-12-14 17:17:33]

lgtm

[commit-bot: I haz the power, 2011-12-14 17:19:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/8919007/4002

[commit-bot: I haz the power, 2011-12-14 18:53:40]

Change committed as 114464