Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Unified Diff: runtime/vm/dart_entry.h

Issue 8918028: If an unhandled exception occurs in Dart_RunLoop, pass it out to the caller. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.h
===================================================================
--- runtime/vm/dart_entry.h (revision 2436)
+++ runtime/vm/dart_entry.h (working copy)
@@ -23,6 +23,13 @@
// DartEntry abstracts functionality needed to resolve dart functions
// and invoke them from C++.
+//
+// TODO(turnidge): Make these functions assert that there is an active
+// setjmp. Or make these functions do the setjmps themselves and
+// represent compile errors with an explict object type.
+//
+// TODO(turnidge): Make these functions return RawObject instead of
+// RawInstance.
class DartEntry : public AllStatic {
public:
typedef RawInstance* (*invokestub)(uword entry_point,
@@ -63,6 +70,11 @@
const GrowableArray<const Object*>& arguments);
static RawInstance* ToString(const Instance& receiver);
static RawInstance* Equals(const Instance& left, const Instance& right);
+
+ // Returns either an unhandled exception or null.
+ static RawObject* HandleMessage(Dart_Port dest_port_id,
+ Dart_Port reply_port_id,
+ const Instance& dart_message);
};
} // namespace dart
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/dart_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698