chrome/browser/ui/gtk/tabs/drag_data.cc - Issue 8918021: Fixing browser crash in the linux tab dragging code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tabs/drag_data.cc

Issue 8918021: Fixing browser crash in the linux tab dragging code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/tabs/drag_data.cc

diff --git a/chrome/browser/ui/gtk/tabs/drag_data.cc b/chrome/browser/ui/gtk/tabs/drag_data.cc

index 99588aa3b006950e43813c55a0ed8016794615f9..11317927c364fb23cbd21ac6e612812534fe3629 100644

--- a/chrome/browser/ui/gtk/tabs/drag_data.cc

+++ b/chrome/browser/ui/gtk/tabs/drag_data.cc

@@ -98,7 +98,8 @@ TabContentsWrapper* DragData::GetSourceTabContentsWrapper() {

}

TabContents* DragData::GetSourceTabContents() {

- return GetSourceTabData()->contents_->tab_contents();

+ TabContentsWrapper* contents = GetSourceTabData()->contents_;

+ return contents != NULL ? contents->tab_contents(): NULL;

Lei Zhang 2011/12/12 22:31:26 nit: you can omit "!= NULL"

dpapad 2011/12/12 22:36:47 Done.

}

DraggedTabData* DragData::GetSourceTabData() {

« no previous file with comments | « no previous file | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc » ('j') | no next file with comments »