Fixing browser crash in the linux tab dragging code.

Fixing browser crash in the linux tab dragging code.

BUG=106772
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114144

[dpapad, 2011-12-12 22:26:14]

I believe this should address both crashes included in the bug description. I
guess the only way to confirm is to land and then check the crash reports daily.

[dpapad, 2011-12-12 22:28:02]

On 2011/12/12 22:26:14, dpapad wrote:
> I believe this should address both crashes included in the bug description. I
> guess the only way to confirm is to land and then check the crash reports
daily.

@sky
Could you please take a look?

[Lei Zhang, 2011-12-12 22:31:26]

I believe sky gets the OWNERS LG?

http://codereview.chromium.org/8918021/diff/1/chrome/browser/ui/gtk/tabs/drag...
File chrome/browser/ui/gtk/tabs/drag_data.cc (right):

http://codereview.chromium.org/8918021/diff/1/chrome/browser/ui/gtk/tabs/drag...
chrome/browser/ui/gtk/tabs/drag_data.cc:102: return contents != NULL ?
contents->tab_contents(): NULL;
nit: you can omit "!= NULL"

[dpapad, 2011-12-12 22:36:47]

Addressed comment.

@sky
Could you take a look?

http://codereview.chromium.org/8918021/diff/1/chrome/browser/ui/gtk/tabs/drag...
File chrome/browser/ui/gtk/tabs/drag_data.cc (right):

http://codereview.chromium.org/8918021/diff/1/chrome/browser/ui/gtk/tabs/drag...
chrome/browser/ui/gtk/tabs/drag_data.cc:102: return contents != NULL ?
contents->tab_contents(): NULL;
On 2011/12/12 22:31:26, Lei Zhang wrote:
> nit: you can omit "!= NULL"

Done.

[Lei Zhang, 2011-12-12 22:44:58]

lgtm

[sky, 2011-12-13 00:11:49]

LGTM

[commit-bot: I haz the power, 2011-12-13 00:22:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpapad@chromium.org/8918021/2003

[commit-bot: I haz the power, 2011-12-13 01:42:03]

Change committed as 114144