Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8918017: Bug fix for computing partitions in subranges of the document (Closed)

Created:
9 years ago by Brian Wilkerson
Modified:
9 years ago
Reviewers:
messick, pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bug fix for computing partitions in subranges of the document (http://code.google.com/p/dart/issues/detail?id=816) Committed: https://code.google.com/p/dart/source/detail?r=2357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/functions/FastDartPartitionScanner.java View 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
9 years ago (2011-12-12 21:43:13 UTC) #1
pquitslund
lgtm
9 years ago (2011-12-12 21:49:29 UTC) #2
messick
lgtm Might be good to add a test if this isn't already covered.
9 years ago (2011-12-12 21:49:31 UTC) #3
Brian Wilkerson
9 years ago (2011-12-12 22:01:49 UTC) #4
> Might be good to add a test if this isn't already covered.

Agreed. Unfortunately I don't know how to force the document to ask the
partitioner to partition a range within the document. If you do, please let me
know.

Powered by Google App Engine
This is Rietveld 408576698