Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8462)

Unified Diff: chrome/common/logging_chrome_uitest.cc

Issue 8918011: Mark RendererCrashTest.Crash test as flaky on ChromiumOS (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Use MAYBE Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome_uitest.cc
diff --git a/chrome/common/logging_chrome_uitest.cc b/chrome/common/logging_chrome_uitest.cc
index d4bbfa1ba92122ed32eb3e94ace740eed6fa2ced..868ac8600d5143502065a1b974ad99099db09483 100644
--- a/chrome/common/logging_chrome_uitest.cc
+++ b/chrome/common/logging_chrome_uitest.cc
@@ -158,10 +158,14 @@ class RendererCrashTest : public UITest {
#if defined(OS_MACOSX)
// Crash service doesn't exist for the Mac yet: http://crbug.com/45243
-#define Crash DISABLED_Crash
+#define MAYBE_Crash DISABLED_Crash
+#elif defined(OS_CHROME)
+#define MAYBE_Crash FLAKY_Crash
+#else
+#define MAYBE_Crash Crash
#endif
// Launch the app in renderer crash test mode, then close the app.
-TEST_F(RendererCrashTest, Crash) {
+TEST_F(RendererCrashTest, MAYBE_Crash) {
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
ASSERT_TRUE(browser.get());
ASSERT_TRUE(browser->WaitForTabCountToBecome(1));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698