Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 8918011: Mark RendererCrashTest.Crash test as flaky on ChromiumOS (Closed)

Created:
9 years ago by willchan no longer on Chromium
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Mark RendererCrashTest.Crash test as flaky on ChromiumOS It has been flaky on the trybots. BUG=107226 TEST=RendererCrashTest.Crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114159

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use MAYBE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/common/logging_chrome_uitest.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
9 years ago (2011-12-12 18:20:49 UTC) #1
grt (UTC plus 2)
LGTM w/ a nit. http://codereview.chromium.org/8918011/diff/1/chrome/common/logging_chrome_uitest.cc File chrome/common/logging_chrome_uitest.cc (right): http://codereview.chromium.org/8918011/diff/1/chrome/common/logging_chrome_uitest.cc#newcode166 chrome/common/logging_chrome_uitest.cc:166: TEST_F(RendererCrashTest, Crash) { would you ...
9 years ago (2011-12-12 18:33:27 UTC) #2
willchan no longer on Chromium
Sure http://codereview.chromium.org/8918011/diff/1/chrome/common/logging_chrome_uitest.cc File chrome/common/logging_chrome_uitest.cc (right): http://codereview.chromium.org/8918011/diff/1/chrome/common/logging_chrome_uitest.cc#newcode166 chrome/common/logging_chrome_uitest.cc:166: TEST_F(RendererCrashTest, Crash) { On 2011/12/12 18:33:27, grt wrote: ...
9 years ago (2011-12-12 18:38:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/8918011/3003
9 years ago (2011-12-13 01:13:04 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-13 02:45:36 UTC) #5
Change committed as 114159

Powered by Google App Engine
This is Rietveld 408576698