Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8918005: Adding UMA stats for requestFileSystem error analysis. (Closed)

Created:
9 years ago by tzik
Modified:
9 years ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding UMA stats for requestFileSystem error analysis. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114448

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M webkit/fileapi/sandbox_mount_point_provider.cc View 5 chunks +25 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
tzik
Hi, kinuko-san. I'd like to add UMA stats to investigate errors on requestFileSystem. Could you ...
9 years ago (2011-12-12 13:50:15 UTC) #1
kinuko
On 2011/12/12 13:50:15, tzik wrote: > Hi, kinuko-san. > I'd like to add UMA stats ...
9 years ago (2011-12-14 04:22:39 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 05:21:13 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 13:11:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/8918005/1
9 years ago (2011-12-14 14:43:20 UTC) #5
commit-bot: I haz the power
Change committed as 114448
9 years ago (2011-12-14 17:36:33 UTC) #6
kinuko
9 years ago (2011-12-15 04:34:05 UTC) #7
http://codereview.chromium.org/8918005/diff/1/webkit/fileapi/sandbox_mount_po...
File webkit/fileapi/sandbox_mount_point_provider.cc (right):

http://codereview.chromium.org/8918005/diff/1/webkit/fileapi/sandbox_mount_po...
webkit/fileapi/sandbox_mount_point_provider.cc:359: kFileSystemErrorMax);
Tzik-san, I know this patch has been already landed but could we add slightly
more detailed metrics for this case?
GetDirectoryForOriginAndType could fail for various reasons and I suspect this
one would be the primary hot error spot.
(For example if it's failing due to CURRENT file corruption in origin db like
the one reported in 103018 the error must come from GetDirectoryForOrigin() =>
OriginDatabase::GetPathForOrigin() => OriginDatabase::Init().

Powered by Google App Engine
This is Rietveld 408576698