Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8917029: GTK: Make bookmarks droped from different profiles copy the bookmark. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Make bookmarks droped from different profiles copy the bookmark. This moves us to the same cross platform utility methods as views and cocoa, and fixes a DCHECK(). BUG=102772 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
9 years ago (2011-12-13 01:04:44 UTC) #1
Evan Stade
lgtm
9 years ago (2011-12-13 04:48:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8917029/1
9 years ago (2011-12-13 17:36:34 UTC) #3
commit-bot: I haz the power
Try job failure for 8917029-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-13 18:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8917029/1
9 years ago (2011-12-13 18:39:33 UTC) #5
commit-bot: I haz the power
Try job failure for 8917029-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-13 19:42:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8917029/1
9 years ago (2011-12-13 20:21:08 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-13 22:34:34 UTC) #8 
Change committed as 114292

Powered by Google App Engine
This is Rietveld 408576698