Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 8917028: Add BrowserThread::PostTaskOnIOThread (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, darin (slow to review)
Visibility:
Public.

Description

Add BrowserThread::PostTaskOnIOThread BUG=None TEST=None

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M content/browser/browser_thread_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 3 chunks +2 lines, -9 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
Review at http://codereview.chromium.org/8921017/ suggested it could be useful, but I wanted to limit scope and ...
9 years ago (2011-12-13 00:47:21 UTC) #1
darin (slow to review)
http://codereview.chromium.org/8917028/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/8917028/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc#newcode551 content/browser/renderer_host/render_widget_host_view_win.cc:551: BrowserThread::PostTaskOnIOThread( given how small this change is, maybe the ...
9 years ago (2011-12-13 00:51:35 UTC) #2
piman
On Mon, Dec 12, 2011 at 4:51 PM, <darin@chromium.org> wrote: > > http://codereview.chromium.**org/8917028/diff/1/content/** > browser/renderer_host/render_**widget_host_view_win.cc<http://codereview.chromium.org/8917028/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc> ...
9 years ago (2011-12-13 00:54:06 UTC) #3
jam
9 years ago (2011-12-13 11:55:58 UTC) #4
I think it's better not to add this, because it saves a small amount of code
that people are already familiar with. we shouldn't treat specific threads
differently in BrowserThread's API

Powered by Google App Engine
This is Rietveld 408576698