Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: chrome/browser/sync/test/integration/migration_errors_test.cc

Issue 8917010: Marking MigrationTwoClientTest.MigrationHellWithoutNigori flaky on Mac 10.6. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(akalin): Rename this file to migration_test.cc. 5 // TODO(akalin): Rename this file to migration_test.cc.
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "chrome/browser/prefs/scoped_user_pref_update.h" 8 #include "chrome/browser/prefs/scoped_user_pref_update.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sync/profile_sync_service_harness.h" 10 #include "chrome/browser/sync/profile_sync_service_harness.h"
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 // Triggers a server migration on two datatypes, then makes a local 344 // Triggers a server migration on two datatypes, then makes a local
345 // modification to one of them. 345 // modification to one of them.
346 // Flaky. crbug.com/100382. 346 // Flaky. crbug.com/100382.
347 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, 347 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
348 FLAKY_MigratePrefsAndBookmarksThenModifyBookmark) { 348 FLAKY_MigratePrefsAndBookmarksThenModifyBookmark) {
349 RunTwoClientMigrationTest( 349 RunTwoClientMigrationTest(
350 MakeList(syncable::PREFERENCES, syncable::BOOKMARKS), 350 MakeList(syncable::PREFERENCES, syncable::BOOKMARKS),
351 MODIFY_BOOKMARK); 351 MODIFY_BOOKMARK);
352 } 352 }
353 353
354 // Flaky on Mac 10.6 Sync bot: http://crbug.com/107205.
355 #if defined(OS_MACOSX)
356 #define MAYBE_MigrationHellWithoutNigori FLAKY_MigrationHellWithoutNigori
357 #else
358 #define MAYBE_MigrationHellWithoutNigori MigrationHellWithoutNigori
359 #endif
360
354 // Migrate every datatype in sequence; the catch being that the server 361 // Migrate every datatype in sequence; the catch being that the server
355 // will only tell the client about the migrations one at a time. 362 // will only tell the client about the migrations one at a time.
356 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithoutNigori) { 363 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
364 MAYBE_MigrationHellWithoutNigori) {
357 ASSERT_TRUE(SetupClients()); 365 ASSERT_TRUE(SetupClients());
358 MigrationList migration_list = GetPreferredDataTypesList(); 366 MigrationList migration_list = GetPreferredDataTypesList();
359 // Let the first nudge be a datatype that's neither prefs nor 367 // Let the first nudge be a datatype that's neither prefs nor
360 // bookmarks. 368 // bookmarks.
361 migration_list.push_front(MakeSet(syncable::THEMES)); 369 migration_list.push_front(MakeSet(syncable::THEMES));
362 RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK); 370 RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
363 } 371 }
364 372
365 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithNigori) { 373 IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithNigori) {
366 ASSERT_TRUE(SetupClients()); 374 ASSERT_TRUE(SetupClients());
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 449
442 // Phase 5: Verify that preferences can still be synchronized. 450 // Phase 5: Verify that preferences can still be synchronized.
443 VerifyPrefSync(); 451 VerifyPrefSync();
444 452
445 // Phase 6: Verify that sessions are registered and enabled. 453 // Phase 6: Verify that sessions are registered and enabled.
446 ASSERT_TRUE(GetClient(0)->IsTypeRunning(syncable::SESSIONS)); 454 ASSERT_TRUE(GetClient(0)->IsTypeRunning(syncable::SESSIONS));
447 ASSERT_TRUE(GetClient(0)->IsTypePreferred(syncable::SESSIONS)); 455 ASSERT_TRUE(GetClient(0)->IsTypePreferred(syncable::SESSIONS));
448 } 456 }
449 457
450 } // namespace 458 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698