Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 8916020: Second attempt at moving the StackingClient to a property on the RootWindow. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, Paweł Hajdan Jr., sadrul, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Second attempt at moving the StackingClient to a property on the RootWindow. This time, we allow the StackingClient to be optional. If not specified, unparented windows will just be added to the RootWindow. BUG=none TEST=existing automation Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114571

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -190 lines) Patch
M ui/aura/aura.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download
M ui/aura/client/aura_constants.h View 1 1 chunk +12 lines, -8 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/aura/client/stacking_client.h View 1 1 chunk +8 lines, -5 lines 0 comments Download
A ui/aura/client/stacking_client.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M ui/aura/root_window.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/root_window.cc View 1 4 chunks +0 lines, -28 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
D ui/aura/test/test_stacking_client.h View 1 1 chunk +0 lines, -41 lines 0 comments Download
D ui/aura/test/test_stacking_client.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M ui/aura/window.cc View 1 2 chunks +13 lines, -6 lines 0 comments Download
M ui/aura_shell/root_window_event_filter_unittest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M ui/aura_shell/shell.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura_shell/shell.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M ui/aura_shell/stacking_controller.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M ui/aura_shell/stacking_controller.cc View 1 1 chunk +10 lines, -18 lines 0 comments Download
M ui/aura_shell/toplevel_window_event_filter_unittest.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M ui/aura_shell/workspace/workspace_manager_unittest.cc View 1 3 chunks +3 lines, -7 lines 0 comments Download
M ui/aura_shell/workspace_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-14 23:28:31 UTC) #1
sky
LGTM
9 years ago (2011-12-14 23:37:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8916020/1025
9 years ago (2011-12-15 00:33:43 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-15 01:51:12 UTC) #4
Change committed as 114571

Powered by Google App Engine
This is Rietveld 408576698