Issue 8916019: Use a more OO approach to customizing extension API bindings in

Issue 8916019: Use a more OO approach to customizing extension API bindings in (Closed)

Created:
9 years ago by not at google - send to devlin

Modified:
9 years ago

Reviewers:
Aaron Boodman, koz (OOO until 15th September)

CC:
koz (OOO until 15th September), chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a more OO approach to customizing extension API bindings in schema_generated_bindings.js. BUG=80310 TEST=browser_tests --gtest_filter=*Extensions* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114606

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Patch Set 8 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -56 lines)			Patch
	M	chrome/renderer/resources/extensions/schema_generated_bindings.js	View	1 2 3 4 5 6 7	17 chunks	+92 lines, -56 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

First step of the inject-what-you-need patch.

9 years ago (2011-12-15 03:14:26 UTC) #1

Aaron Boodman

http://codereview.chromium.org/8916019/diff/8002/chrome/renderer/resources/extensions/schema_generated_bindings.js File chrome/renderer/resources/extensions/schema_generated_bindings.js (right): http://codereview.chromium.org/8916019/diff/8002/chrome/renderer/resources/extensions/schema_generated_bindings.js#newcode623 chrome/renderer/resources/extensions/schema_generated_bindings.js:623: function ApiFunctions() { Nit: can you name this "APIFunctions"?

9 years ago (2011-12-15 04:37:12 UTC) #3

not at google - send to devlin

9 years ago (2011-12-15 05:53:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/8916019/14002

9 years ago (2011-12-15 06:05:19 UTC) #5

Change committed as 114606

Expand Messages | Collapse Messages