Added storage sample.

Added storage sample.


BUG=98591
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114531

[Boris Smus, 2011-12-14 21:11:50]

Sorry guys, I was horribly out of date. Starting a new review. Ben, Mike LGTM'ed
it previously but I'd like you to take a look before I commit.

[not at google - send to devlin, 2011-12-14 23:04:13]

LGTM after those couple of comments

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/storage/stylizr/options.js
(right):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/options.js:30:
message('Settings saved');
Should probably do this in the callback from set().

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js
(right):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js:5: // Store
settings in the local, un-synchronized repository.
Why not use the synced storage?

An interesting feature might be something neat like putting a "sync this CSS"
option in storage.local, then based on the value of that query use either local
or sync for the settings.

In a follow-up perhaps.

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js:18:
message.innerText = 'Injected style!';
shouldn't this be in an else, or a "return" after line 16?

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/experimental.devtools.console.html (left):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/experimental.devtools.console.html:19: <meta
name="description" content="Documentation for the
chrome.experimental.devtools.console module, which is part of the Google Chrome 
extension APIs."><title>chrome.experimental.devtools.console
These documentation changes are unrelated right (same as a bunch of the docs
changes)?  Revert?

[not at google - send to devlin, 2011-12-14 23:16:07]

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js
(right):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js:5: // Store
settings in the local, un-synchronized repository.
On 2011/12/14 23:04:13, kalman wrote:
> Why not use the synced storage?
> 
> An interesting feature might be something neat like putting a "sync this CSS"
> option in storage.local, then based on the value of that query use either
local
> or sync for the settings.
> 
> In a follow-up perhaps.

Or just always use sync, local should be an exception to the rule.

[Boris Smus, 2011-12-14 23:29:34]

Thanks Ben!

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/storage/stylizr/options.js
(right):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/options.js:30:
message('Settings saved');
On 2011/12/14 23:04:13, kalman wrote:
> Should probably do this in the callback from set().

Done.

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js
(right):

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js:5: // Store
settings in the local, un-synchronized repository.
On 2011/12/14 23:04:13, kalman wrote:
> Why not use the synced storage?
> 
> An interesting feature might be something neat like putting a "sync this CSS"
> option in storage.local, then based on the value of that query use either
local
> or sync for the settings.
> 
> In a follow-up perhaps.

Switched to sync for now. Option could be interesting later.

http://codereview.chromium.org/8916013/diff/3001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/storage/stylizr/popup.js:18:
message.innerText = 'Injected style!';
On 2011/12/14 23:04:13, kalman wrote:
> shouldn't this be in an else, or a "return" after line 16?

Done.