Issue 8916010: Reverting issues 8873036 and issues 8933010

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8916010: Reverting issues 8873036 and issues 8933010 (Closed)

Created:
9 years ago by Emmanuel Saint-loubert-Bié

Modified:
9 years ago

Reviewers:
oshima, DaveMoore, sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reverting issues 8873036 and issues 8933010 http://codereview.chromium.org/8933010/ caused a regression in interactive_ui_tests on Linux+Aura+ChromeOS http://codereview.chromium.org/8873036/ was rebased on the above and had to be reverted TBR=sky@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114472

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -139 lines)			Patch
M	chrome/browser/ui/views/aura/chrome_shell_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/chrome_shell_delegate.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/aura_shell/examples/aura_shell_main.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View	6 chunks	+50 lines, -47 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.h	View	4 chunks	+8 lines, -15 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.cc	View	3 chunks	+28 lines, -44 lines	0 comments	Download
M	ui/aura_shell/shelf_layout_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/shell_delegate.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	ui/aura_shell/toplevel_layout_manager.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
D	ui/resources/aura/launcher_background.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Emmanuel Saint-loubert-Bié

9 years ago (2011-12-14 19:31:01 UTC) #1

Sorry for the inconvenience, trying to land the tests Oshima worked on for the
main waterfall