Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 8916008: [sync] Check for null pointers before calling |FinishConfigureDataTypesOnFrontendLoop| in sbh. (Closed)

Created:
9 years ago by lipalani1
Modified:
9 years ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)
Visibility:
Public.

Description

During shutdown the |host_| pointer and/or |host_->frontend_| could be null. Check for those conditions before calling methods on those pointers. BUG=107279 TEST=unit_tests.exe, sync_unit_tests.exe, sync_integration_tests.exe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/sync/glue/sync_backend_host.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lipalani1
Please review.
9 years ago (2011-12-14 18:41:43 UTC) #1
akalin
On 2011/12/14 18:41:43, lipalani1 wrote: > Please review. LGTM fix typo in CL description ("}" ...
9 years ago (2011-12-14 19:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lipalani@chromium.org/8916008/1
9 years ago (2011-12-14 20:25:51 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-14 21:49:23 UTC) #4
Change committed as 114496

Powered by Google App Engine
This is Rietveld 408576698