Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 8916: Ignore result of calling Heap::CollectGarbage and continue... (Closed)

Created:
12 years, 1 month ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Ignore result of calling Heap::CollectGarbage and continue to try the next allocation. This is consistent with how we handle it when calling from JavaScript to C++. Committed: http://code.google.com/p/v8/source/detail?r=659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/heap-inl.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
12 years, 1 month ago (2008-10-30 14:27:43 UTC) #1
Kevin Millikin (Chromium)
12 years, 1 month ago (2008-10-30 14:29:42 UTC) #2
LGTM with the failure message text updated.

Powered by Google App Engine
This is Rietveld 408576698