Code review changes

frog/var_member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A dynamic member stub. */
 class VarMember {
   final String name;
   bool isGenerated = false;
 
   VarMember(this.name);
@@ skipping 227 matching lines @@
       world.objectType.varStubs[stub.name] = stub;
     }
   }
 
   // TODO(jmesserly): get rid of this as it's unused now
   void generate(CodeWriter code) {}
 }
 
 String _getCallStubName(String name, Arguments args) {
   // TODO: This code needs global knowledge to ensure the stub name does not
-  // collide with any other name.
+  // collide with any other name.  E.g. it is unlikely but possible for the user
+  // to have methods called 'foo' and 'foo$0'.

[Jennifer Messerly, 2011/12/14 22:07:08]

if the user had a method called foo$0, it would get escaped to foo$$0 and hence
not conflict

   final nameBuilder = new StringBuffer('${name}\$${args.bareCount}');
   for (int i = args.bareCount; i < args.length; i++) {
     var name = args.getName(i);
     nameBuilder.add('\$');
     if (name.contains('\$')) {
-      // Disambiguate "a:b:" from "a$b:"
+      // Disambiguate "a:b:" from "a$b:".  Using the length works well because
+      // the names can't start with digits.
       nameBuilder.add('${name.length}');
     }
     nameBuilder.add(name);
   }
   return nameBuilder.toString();
 }