Issue 8915020: Fixing frame rate tests that depend on head_animation.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8915020: Fixing frame rate tests that depend on head_animation.js (Closed)

Created:
9 years ago by Justin Novosad

Modified:
9 years ago

Reviewers:
nduca

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixing frame rate tests that depend on head_animation.js Small oversight in r112774: function __update_fps replaced with __record_frame_time in head.js. __update_fps was still referenced in head_animation.js BUG=http://code.google.com/p/chromium/issues/detail?id=106557 TEST=performance_ui_tests, gpu_frame_rate_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114639

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/test/data/perf/frame_rate/head_animation.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/test/perf/frame_rate/frame_rate_tests.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nduca

Oh. My. God. I can't even. I'm sorry I suck so much! Thank you. LGTM.

9 years ago (2011-12-14 22:00:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/8915020/1

9 years ago (2011-12-15 14:38:35 UTC) #3

Change committed as 114639

Expand Messages | Collapse Messages