Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 8914026: Revert 114539 - Move content::MakeSharedMemorySegmentViaIPC into its own file (Closed)

Created:
9 years ago by Roland McGrath
Modified:
9 years ago
Reviewers:
Roland McGrath
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Revert 114539 - Move content::MakeSharedMemorySegmentViaIPC into its own file The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but none of the other proxy functions in the same source file. Some of those functions refer to symbols that bring in a great deal of other code, e.g. most of v8. We don't want all that code linked into nacl_helper--it bloats the binary by a factor of ten or so. Moving the function out to its own file prevents the other dependencies coming in unnecessarily. BUG= http://code.google.com/p/chromium/issues/detail?id=106986 TEST= still builds and nacl_helper binary is much smaller R=jam@chromium.org,bradchen@google.com Review URL: http://codereview.chromium.org/8893009 TBR=mcgrathr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -39 lines) Patch
M chrome/nacl.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 2 chunks +21 lines, -1 line 0 comments Download
D content/common/child_process_sandbox_support_impl_shm_linux.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Roland McGrath
9 years ago (2011-12-15 00:27:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698