Issue 8914023: Relands fixes for 106432, 107287 and 107401. These got reverted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8914023: Relands fixes for 106432, 107287 and 107401. These got reverted (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Relands fixes for 106432, 107287 and 107401. These got reverted together, so I'm relanding together. Here's the original descriptions: Fixes layout bugs in ShelfLayoutManager. The problem with invoking SetBounds on the widget during the animation is we end up back in the layoutmanager and cancel the change. Also adds some tests for ShelfLayoutManager. and Create a visible shelf and constrain window movement This also includes the fix, which you reviewed @ http://codereview.chromium.org/8914012 . BUG=106432 107287 107401 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114502

Patch Set 1 #

Patch Set 2 : Da fix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -91 lines)			Patch
M	chrome/browser/ui/views/aura/chrome_shell_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/aura/chrome_shell_delegate.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/aura_shell_main.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View	1	6 chunks	+49 lines, -50 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.h	View		4 chunks	+15 lines, -8 lines	0 comments	Download
M	ui/aura_shell/launcher/tabbed_launcher_button.cc	View		3 chunks	+44 lines, -28 lines	0 comments	Download
M	ui/aura_shell/shelf_layout_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura_shell/shell_delegate.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura_shell/test/test_shell_delegate.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	ui/aura_shell/toplevel_layout_manager.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
A	ui/resources/aura/launcher_background.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

Patchset 1 is what was reverted. Patchset 2 includes the fix @ http://codereview.chromium.org/8914012/ . TBRing ...

9 years ago (2011-12-14 22:15:02 UTC) #1

lgtm

Expand Messages | Collapse Messages