Check for delegate in OnMouseEvent

Check for delegate in OnMouseEvent

Change-Id: I78ca835371a0cf70e3dcb7630a91838ca40e9005

BUG=107596
TEST=See issue

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114513

[stevenjb, 2011-12-14 20:25:14]

Since this is already a bit of a hack with a TODO, adding a check to avoid a
crash from Web UI dropdown menus seemed reasonable. I confirmed that this
doesn't appear to affect the functionality of the dropdown menu.

[Ben Goodger (Google), 2011-12-14 20:32:53]

LGTM

On Wed, Dec 14, 2011 at 12:25 PM, <stevenjb@chromium.org> wrote:

> Reviewers: pkotwicz1, Ben Goodger (Google),
>
> Message:
> Since this is already a bit of a hack with a TODO, adding a check to avoid
> a
> crash from Web UI dropdown menus seemed reasonable. I confirmed that this
> doesn't appear to affect the functionality of the dropdown menu.
>
>
> Description:
> Check for delegate in OnMouseEvent
>
> Change-Id: I78ca835371a0cf70e3dcb7630a918**38ca40e9005
>
> BUG=107596
> TEST=See issue
>
>
> Please review this at
http://codereview.chromium.**org/8914017/<http://codereview.chromium.org/8914...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M content/browser/renderer_host/**render_widget_host_view_aura.**cc
>
>
> Index: content/browser/renderer_host/**render_widget_host_view_aura.**cc
> diff --git a/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> b/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> index fe86f4814f59e034d9e4cd5300c55d**c1b185d744..**
> ea3d544054ad4812ad8dc07b8ad513**70e38a2395 100644
> --- a/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> +++ b/content/browser/renderer_**host/render_widget_host_view_**aura.cc
> @@ -522,7 +522,8 @@ bool
RenderWidgetHostViewAura::**OnMouseEvent(aura::MouseEvent*
> event) {
>
>   // Needed to propagate mouse event to native_tab_contents_view_aura.
>   // TODO(pkotwicz): Find a better way of doing this.
> -  window_->parent()->delegate()-**>OnMouseEvent(event);
> +  if (window_->parent()->delegate()**)
> +    window_->parent()->delegate()-**>OnMouseEvent(event);
>
>   // Return true so that we receive released/drag events.
>   return true;
>
>
>

[commit-bot: I haz the power, 2011-12-14 20:38:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8914017/1

[commit-bot: I haz the power, 2011-12-14 21:50:56]

Try job failure for 8914017-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...